On Tue, 19 Nov 2024 01:17:55 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
> Expunge the use of the `SecurityManager`, `AccessController`, and the like
> from the `jdk.sctp` module.
src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.java line 1085:
> 1083: }
> 1084:
> 1085: @SuppressWarnings({"removal", "restricted"})
You can remove "removal" from the annotation.
src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java line 243:
> 241:
> 242: IOUtil.configureBlocking(newfd, true);
> 243: InetSocketAddress isa = isaa[0];
You don't need this variable anymore.
src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java line 244:
> 242: IOUtil.configureBlocking(newfd, true);
> 243: InetSocketAddress isa = isaa[0];
> 244: sc = new SctpChannelImpl(provider(), newfd);
You don't need `sc` anymore - you can just return here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22225#discussion_r1848413897
PR Review Comment: https://git.openjdk.org/jdk/pull/22225#discussion_r1848422198
PR Review Comment: https://git.openjdk.org/jdk/pull/22225#discussion_r1848424626
