On Fri, 22 Nov 2024 11:08:36 GMT, Daniel Fuchs <[email protected]> wrote:
>> Please find here a patch that removes use of SecurityManager and
>> doPrivileged in DatagramSocket/MulticastSocket implementation.
>>
>> Some allusion to the SecurityManager was missed in DatagramSocket::connect,
>> so this patch contains a small API documentation change that will require a
>> CSR.
>
> Daniel Fuchs has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains three additional
> commits since the last revision:
>
> - Simplify wording in DatagramSocket::connect
> - Merge branch 'master' into DS-SM-8344217
> - 8344217: Remove calls to SecurityManager and and doPrivileged in
> java.net.DatagramSocket and java.net.NetMulticastSocket after JEP 486
> integration
Marked as reviewed by alanb (Reviewer).
src/java.base/share/classes/java/net/NetMulticastSocket.java line 309:
> 307: // pending packets to filter. If explicitFilter is true,
> 308: // it means we're connected.
> 309: if (explicitFilter) {
Maybe some day we will be able to re-visit this and just have connect flush any
pending datagrams.
-------------
PR Review: https://git.openjdk.org/jdk/pull/22303#pullrequestreview-2454233608
PR Review Comment: https://git.openjdk.org/jdk/pull/22303#discussion_r1853790282
