On Fri, 29 Nov 2024 12:29:41 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Volkan Yazıcı has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Further simplify the test > > test/jdk/java/net/Socket/CtorFailTest.java line 211: > >> 209: throw new UnsupportedOperationException(); >> 210: } >> 211: > > IIRC Junit should print the test method arguments before running a test. I'd > suggest adding a toString here, so that when a test fails we know which > scenario is failing. That is indeed a (really) nice to have. Added in cf86230d44c1bbde7e67be86692fa36721ddd28c. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22439#discussion_r1863518965
