On Mon, 2 Dec 2024 14:16:02 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >> changes are trivial. The >> `src/java.base/linux/classes/jdk/internal/platform/CgroupUtil.java` used to >> expose utility methods for dealing with SecurityManager permissions and it >> was called from a few places. That class is no longer needed with the clean >> up done in this PR. >> >> No new tests have been introduced and tier testing is currently in progress. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > Update > src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java > > Co-authored-by: Severin Gehwolf <jerb...@gmail.com> cgroups changes look good. Haven't looked at the other bits. src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java line 29: > 27: package jdk.internal.platform; > 28: > 29: import java.io.BufferedReader; Unused now? ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22478#pullrequestreview-2472822295 PR Review Comment: https://git.openjdk.org/jdk/pull/22478#discussion_r1865928383
