On Sat, 30 Nov 2024 18:18:29 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
> Please review this PR which suggests to make the constructor of > `java.net.InterfaceAddress` private. > > This constructor is only accessed by native code via the `NetworkInterface` > class. Making it private would express the intent of this class as being > non-subclassable. > > The comment of the constructor is updated to reflect the new access modifier > as well as to make it clear that the constructor is not to be invoked from > Java code and that instances are obtained from `NetworkInterface` via native > code. > > Marking this class final is handled separately in JDK-8344943 via a CSR. This pull request has now been integrated. Changeset: 077b8422 Author: Eirik Bjørsnøs <eir...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/077b8422bb5bf70fb6201b71911741e2aff9a520 Stats: 4 lines in 1 file changed: 0 ins; 1 del; 3 mod 8345074: java.net.InterfaceAddress constructor could be made private Reviewed-by: jpai ------------- PR: https://git.openjdk.org/jdk/pull/22467