On Wed, 15 Jan 2025 10:50:55 GMT, Volkan Yazıcı <[email protected]> wrote:
>> Adds `limiting()` factory methods to
>> `HttpResponse.Body{Handlers,Subscribers}` to handle excessive server input
>> in `HttpClient`. I would appreciate your input whether `discardExcess`
>> should be kept or dropped. I plan to file a CSR once there is an agreement
>> on the PR.
>
> Volkan Yazıcı has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove concurrency measures (methods are accessed serially due to the
> Reactive Streams spec)
src/java.net.http/share/classes/jdk/internal/net/http/LimitingSubscriber.java
line 107:
> 105:
> 106: // Otherwise, trigger failure
> 107: else {
Nit - this `else` feels a bit "far" away from the corresponding `if`. Perhaps
you could consider changing it to something like:
if {
...
} else { // Otherwise, trigger failure
...
}
or even,
if {
...
} else {
// Otherwise, trigger failure
...
}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23096#discussion_r1916723329
