On Wed, 22 Jan 2025 15:18:45 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Merge branch 'master' into AggregatePublisher-8348108 >> - Fields could be final in test class >> - Review feedback >> - Merge branch 'master' into AggregatePublisher-8348108 >> - 8348108: Race condition in AggregatePublisher.AggregateSubscription > > src/java.net.http/share/classes/jdk/internal/net/http/RequestPublishers.java > line 575: > >> 573: subscription.cancel(); >> 574: } >> 575: // This nethod is called when cancel is true, so > > Typo - should have been "method". Fixed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23204#discussion_r1925530051
