On Sun, 2 Feb 2025 13:20:39 GMT, Jaikiran Pai <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove `assertFileContentsEqual()`
>
> test/lib/jdk/test/lib/Asserts.java line 623:
>
>> 621: * @throws IOException on I/O failures
>> 622: */
>> 623: public static void assertFileContentsEqual(Path f1, Path f2) throws
>> IOException {
>
> Hello Volkan, is this new method needed? Can its call sites instead be
> replaced with `java.nio.file.Files.mismatch(...)` call?
I thought it reports more useful diagnostics compared to the earlier `file
compare failed` message. Nevertheless, replaced it with `Files::mismatch` in
421d19d468d62bdb04aee458c72a338a5c053e73.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23401#discussion_r1939052590
