On Tue, 11 Feb 2025 09:51:59 GMT, Jaikiran Pai <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review feedback
>
> src/java.net.http/share/classes/jdk/internal/net/http/common/SSLTube.java
> line 644:
>
>> 642: @Override
>> 643: public void request(long n) {
>> 644: final long demand = n;
>
> Hello Daniel, is this `demand` variable necessary? From what I see, we could
> just keep using `n` wherever we use `demand` in this method. I think that
> would also avoid the confusion between `demanded` and this `demand` variables
> that are used in this method.
OK
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23515#discussion_r1950545432
