On Mon, 10 Feb 2025 10:53:12 GMT, Daniel Fuchs <[email protected]> wrote:
>> java.net.URI.scanIPv4Address is a private method, it is only called by
>> java.net.URI.takeIPv4Address and java.net.URI.parseIPv4Address, the
>> URISyntaxException("Malformed IPv4 address") is not necessary, returning -1
>> should be good. In one of our systems, we noticed the exception consumes
>> ~0.3% CPU.
>>
>> Additional test:
>> - [x] make test TEST=jdk/java/net
>> - [x] all tier2 tests(except DirectIOTest.java which is a [known
>> issue](https://bugs.openjdk.org/browse/JDK-8333783))
>
> What tests did you run against those changes? You will need to run at least
> tier2 tests.
@dfuch
Hi Daniel, thank you for the review of the changes, do you have other concerns
on the PR?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23538#issuecomment-2670172037
