On Mon, 3 Mar 2025 10:40:22 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> "Network setup issue" more concisely
>
> test/jdk/java/net/InetAddress/IsReachableViaLoopbackTest.java line 64:
>
>> 62: } catch (java.net.UnknownHostException e) {
>> 63: e.printStackTrace();
>> 64: throw new SkippedException("Network setup issue, skip this
>> test");
>
> Minor: Do you think it would make the comment cleaner if it would be just
> `"Network setup issue"`? It seems to be repeating itself for me (skip
> exception already states, that the test is skipped).
>
> Don't have a strong opinion, so it's completely up you :)
>
> Also this is the same for the line 60 in the `getOriginalHostName.java`
"Network setup issue" more concisely, PR has been updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23767#discussion_r1977316333
