On Fri, 7 Mar 2025 15:53:22 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

> This is a trivial doc cleanup. HttpResponse and module-info have a few links 
> that should use {@linkplain } instead of {@link } or <href>. Also I noticed 
> one link target mismatch, and some clarification missing in the send/receive 
> buffer properties.

Looks fine. Minor formatting nit aside

src/java.net.http/share/classes/java/net/http/HttpResponse.java line 432:

> 430:          * BodySubscribers.fromLineSubscriber(subscriber, finisher, 
> charset, lineSeparator)},
> 431:          * with the given {@code subscriber}, {@code finisher} function, 
> and line separator.
> 432:          * The {@linkplain  Charset charset} used to decode the response 
> body bytes is

Suggestion:

         * The {@linkplain Charset charset} used to decode the response body 
bytes is

-------------

Marked as reviewed by michaelm (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23945#pullrequestreview-2667803078
PR Review Comment: https://git.openjdk.org/jdk/pull/23945#discussion_r1985378139

Reply via email to