On Thu, 13 Mar 2025 01:57:20 GMT, Archie Cobbs <[email protected]> wrote:
>> src/java.base/share/classes/java/text/MessageFormat.java line 327:
>>
>>> 325: * <th scope="row" style="font-weight:normal">{@code unit}
>>> 326: * <td>{@link ListFormat#getInstance(Locale, ListFormat.Type,
>>> ListFormat.Style)
>>> 327: * ListFormat.getInstance}{@code (getLocale()}, {@link
>>> ListFormat.Type#UNIT}, {@link ListFormat.Style#FULL})
>>
>> The new ')' at the end of the line. Where's the matching '('? I'm guessing
>> that the IDE thinks it's the one immediately before the `getLocale()`, but I
>> suspect that javadoc won't agree with that.
>
>> Where's the matching `(`? I'm guessing that the IDE thinks it's the one
>> immediately before the `getLocale()`, but I suspect that javadoc won't agree
>> with that.
>
> You are correct - the matching `(` is the one preceding `getLocale()`.
>
> I'm not sure what you mean by "I suspect that javadoc won't agree with that".
> This change is simply making this row of the table consistent with the ones
> above it. You can see how they currently appear
> [here](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/text/MessageFormat.html).
> In this row, the closing `}` should have been a `)`.
>
> Thanks for taking a look.
Shouldn't this closing `)` be wrapped in `{@code}` like `{@code )}` to match
with the code format in `{@code (getLocale()}`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24022#discussion_r2009479111
