On Thu, 3 Apr 2025 10:12:44 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
> My tests came back green - but it wouldn't hurt to have another > reviewer/committer eyeball these changes before integrating. As far as I > could tell - the code with the new changes is strictly equivalent to the old. Thanks Daniel! I've tried performing changes rather mechanically and step-by-step, leaning on safe IDE refactorings where possible. But yes, would be great with a second pair of eyes! (@jaikiran is known to have great eyes!) The two parts which may need focus is: * To verify that `ParseUtil::isLocalFileURL` is indeeed equivalient to the old/removed `URLJarFile::isFileURL`. * That the logic in `JarFileFactory::urlFor` survived the accomodations to use `ParseUtil::isLocalFileURL` (flipping (!=) to !(||), etc) The remaining changes are of a more trivial kind. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24332#issuecomment-2775312586
