On Fri, 4 Apr 2025 09:13:30 GMT, Daishi Tabata <d...@openjdk.org> wrote:
>> The output `jwebserver` and `java -m jdk.httpserver` uses UTF-8 encoding. >> Therefore, if the console encoding is not set to UTF-8 (for example, MS932 >> on Japanese Windows), garbled characters may appear. >> Since System.out knows the console's encoding, there's no need to specify it >> again with PrintWriter constructor. >> >> The output `jwebserver` and `java -m jdk.httpserver` is localized in >> Japanese, German, and Chinese. This bug only occurs in these localized >> languages, so I haven't added any tests. >> I have confirmed that the output of the two commands is not garbled in the >> default command prompts of both Japanese Windows and English Windows. >> >> I tested jdk/com/sun/net/httpserver/simpleserver on English Windows, and all >> tests passed. However, when running on Japanese Windows, some tests failed >> because they expected output only in English. >> I modified the tests so that `jwebserver` and `java -m jdk.httpserver` >> within the tests are executed with an English locale. After this >> modification, all tests passed on Japanese Windows. > > Daishi Tabata has updated the pull request incrementally with one additional > commit since the last revision: > > Update full name > Upon reconsideration, these tests were failing on Japanese Windows even > before the fix. > Should I issue a separate Bug ID? That's what I suspected. I just wanted to make sure that needing the locale was not a side effect of your changes. That said - I believe our tests are typically expecting the CI system (or make)? to set Locale.ENGLISH before running the tests. I'm good with the changes you're proposing. Please hold on integrating for a bit - I would like to verify that there no regression in our CI. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24437#issuecomment-2778586005
