On Fri, 4 Apr 2025 10:31:08 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>> Ok - I see that 127.0.0.1 should not be directly used. Would it work if we >> replaced that with a fake host name then? > >> Ok - I see that 127.0.0.1 should not be directly used. Would it work if we >> replaced that with a fake host name then? > > Yeah, you're right, the FTP request never materializes (our proxy just > swallows it). So we only use it to assert against what was requested from the > proxy, we can use a fake host name. > > Any preference/precedence for fake host names? Generally looks good. "127.0.0.1" rings alarm bells because we're trying to make our tests independent of the IP versions supported by the machine they run on. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24418#discussion_r2028577797
