On Wed, 9 Apr 2025 11:32:38 GMT, Daniel Fuchs <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Apply review suggestions
>
> test/jdk/java/net/httpclient/EmptyAuthenticate.java line 103:
>
>> 101: : HttpTestServer.create(version);
>> 102: HttpTestHandler handler = new
>> ServerHandlerRespondingWithEmptyWwwAuthHeader();
>> 103: server.addHandler(handler, "/");
>
> Suggestion:
>
> server.addHandler(handler, "/EmptyAuthenticate/");
Applied it in 7b5c849002c2302a3b4d4cdec3fd427fc9a1c4f7.
> test/jdk/java/net/httpclient/EmptyAuthenticate.java line 137:
>
>> 135:
>> 136: private static HttpRequest createRequest(HttpTestServer server,
>> boolean secure) {
>> 137: URI uri = URI.create("%s://%s/".formatted(secure ? "https" :
>> "http", server.serverAuthority()));
>
> Suggestion:
>
> URI uri = URI.create("%s://%s/EmptyAuthenticate/%s".formatted(secure
> ? "https" : "http", server.serverAuthority(), server.gerVersion()));
Applied it in 7b5c849002c2302a3b4d4cdec3fd427fc9a1c4f7.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24542#discussion_r2035387734
PR Review Comment: https://git.openjdk.org/jdk/pull/24542#discussion_r2035388038
