On Fri, 18 Apr 2025 15:38:02 GMT, Artur Barashev <[email protected]> wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 10 commits:
>>
>> - expanded wildcard imports
>> - Merge branch 'master' into certbuilder
>> - Merge branch 'master' into certbuilder
>> - reversed order of DN strings when making certificates.
>> - Merge branch 'master' into certbuilder
>> - Merge branch 'master' into certbuilder
>> - Merge branch 'master' into certbuilder
>> - Merge branch 'master' into certbuilder
>> - changed boolean array initialization
>> - 8325766: Review seclibs tests for cert expiry
>
> test/lib/jdk/test/lib/security/CertificateBuilder.java line 139:
>
>> 137: */
>> 138: public static SubjectAlternativeNameExtension
>> createDNSSubjectAltNameExt(
>> 139: boolean critical, String dnsName) throws IOException {
>
> Any particular reason for having this method? We already have
> `addSubjectAltNameDNSExt` method below.
It's been a while since I wrote that method but it's probably because the
existing method hardcodes the critical flag to `false`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23700#discussion_r2050800817
