On Wed, 23 Apr 2025 14:58:45 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> 1. What is wrong with `HttpTestServer::close` calling >> `HttpTestServer::stop`, which is already implemented as `impl.close()` by >> `Http2TestServerImpl`? >> 2. Shouldn't we better remove `implements AutoCloseable` and `close()` from >> `Http2TestServerImpl`? > > 1. If the impl is AutoCloseable then close() should call close(). > 2. I would actually prefer to make all implementations AutoCloseable, but > that's not the point of this PR. Implemented changes as requested. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24822#discussion_r2057718592
