On Fri, 25 Apr 2025 06:19:30 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>> Please review this test-only PR which updates `UNCTest.java` to use a UNC >> path which is known to exist. >> >> The test currently uses the file URL >> `file://jdk/LOCAL-JAVA/jdk1.4/win/README.txt`, but since this is unlikely to >> resolve to an existing UNC path on any CI server, the test doesn't really >> verify what it intended to. >> >> This PR changes the test to instead use the path >> `file://computername/C$/Windows`, which should always be available unless >> Administrative Shares has been disabled. We detect this case by using >> File::exists for the path and simply skip the test if it does not exist. >> >> I forced this test to run in tier1 on GHA and verified that it ran >> successfully, without being skipped. Meaning Administrative Shares is >> enabled in the Windows GHA instance. >> >> A test run in Oracle's CI verifying a successful run (without skipping) >> would be welcome. >> >> This is a test only PR, `noreg-self` has been added in the JBS. > > Eirik Bjørsnøs has updated the pull request incrementally with two additional > commits since the last revision: > > - Some spell fixes and comment tweaks > - Use Java-style array declaration Marked as reviewed by dfuchs (Reviewer). I ran the test in our CI, and the test is not skipped. ------------- PR Review: https://git.openjdk.org/jdk/pull/24842#pullrequestreview-2793663917 PR Comment: https://git.openjdk.org/jdk/pull/24842#issuecomment-2830006950
