On Tue, 29 Apr 2025 19:58:42 GMT, Sean Mullan <[email protected]> wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Skip explicit KeyPair initialization and let the provider default set it
>
> test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 52:
>
>> 50:
>> 51: public class SSLSocketParametersTest extends SSLContextTemplate
>> implements
>> 52: Serializable {
>
> As an aside, I can't see any reason this test needs to implement
> Serializable, as nothing in the test depends on it or tests it. I removed it
> locally and the test still passes. Consider removing it as a cleanup (but if
> you do, run it thru mach5 to be safe).
Done, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24756#discussion_r2067427345
