On Thu, 1 May 2025 18:26:03 GMT, Artur Barashev <[email protected]> wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved too fast
>
> test/jdk/javax/net/ssl/ExtendedSSLSession/TLSKeyExporters.java line 324:
>
>> 322: serverBytes = sessls.exportKeyMaterialData("goodbye",
>> 323: bytes, 128);
>> 324: if (Arrays.equals(clientBytes, serverBytes)) {
>
> Replace with `assertEquals/assertNotEquals` this and other test cases?
I am used to writing standalone tests (old days before `test/lib`), but this is
not a bad idea. I used `assertEqualsByteArray`/`assertNotEqualsByteArray` for
`byte[]` and `assertEquals` for `ints`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24976#discussion_r2070734034
