On Tue, 6 May 2025 06:32:33 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> additional changes to SocketImpl.create(...) API javadoc based on review
>> suggestions
>
> src/java.base/share/classes/java/net/Socket.java line 394:
>
>> 392: * @param host the host name, or {@code null} for the
>> loopback address.
>> 393: * @param port the port number.
>> 394: * @param stream a {@code boolean} indicating whether this is
>
> I think the parameter description has to be changed as it no longer indicates
> if the socket is a stream or datatgram socket. I think you can replace with
> something simple, like must be true, false is not allowed.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25031#discussion_r2074865018
