On Tue, 15 Apr 2025 12:00:10 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
> Please help review this PR which disables the unspecified but long-standing > feature where an `FtpURLConnection` is opened as a fallback for non-local > file URLs. > > Before this change, if a file URL has a non-local host component, say > `file://remotehost/folder/data.txt`, then the implementation would attempt > opening an FTP connection to `remotehost`. After this change, such URLs will > be rejected with a `MalformedURLException`, unless the FTP fallback feature > is explicitly re-enabled via a system property. > > This change was initially discussed here: > https://mail.openjdk.org/pipermail/net-dev/2025-March/025988.html > > See the above discussion and CSR draft JDK-8354678 for the motivation for > this change. > > This PR: > > * Changes file URL `Handler::openConnection` implementation for unix/windows > to throw `MalformedURLException`, unless the FTP fallback feature is > explicitly enabled by configuration. > * Introduces a new system property `jdk.net.file.ftpenabled` which when set > to `true` re-enables the feature. > * Documents the new property in `net-properties.html` > * Updates the existing test `NonLocalFtpFallback` to enable the feature via > said system property. > * Adds a new test `NonLocalFtpFallbackDisabled` verifying that a > `MalformedURLException` is thrown by default for a non-local URL host > component. > * Moves testing of exceptional behavior in FtpConnection when using non-local > file URLs with FTP fallback enabled from `OpenStream` to `NonLocalFtpFallback` > > I have added a Release Note as a subtask in the JBS issue, this also needs a > review. This pull request has now been integrated. Changeset: 2ea629f3 Author: Eirik Bjørsnøs <eir...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/2ea629f3f2ae07de9cb92baac13497a789d16ec3 Stats: 166 lines in 7 files changed: 150 ins; 11 del; 5 mod 8353440: Disable FTP fallback for non-local file URLs by default Reviewed-by: dfuchs ------------- PR: https://git.openjdk.org/jdk/pull/24657
