On Thu, 15 May 2025 13:47:23 GMT, serhiysachkov <[email protected]> wrote:
>> change
>> test/jdk/com/sun/net/httpserver/simpleserver/RootDirPermissionsTest.java to
>> a manual test
>
> serhiysachkov has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains three additional
> commits since the last revision:
>
> - 8351843: separating windows test and moving it to manual group
> - Merge branch 'master' into JDK-8351843
> - 8351843:change
> open/test/jdk/com/sun/net/httpserver/simpleserver/RootDirPermissionsTest.java
> to a manual test
test/jdk/com/sun/net/httpserver/simpleserver/DocRootDirPermissionsWinTest.java
line 34:
> 32: */
> 33:
> 34: public class DocRootDirPermissionsWinTest extends
> DocRootDirPermissionsTest{
Hello Serhiy, the test doesn't necessarily have to extend from that other test
and we could probably just make `DocRootDirPermissionsTest.run(String[] args)`
a static method and call that from within the main() method of this
`DocRootDirPermissionsWinTest`. But I see some work was done to make those
methods instance methods instead of static which means that you might have to
revert that. So I think it's fine in the current form and I see Daniel has
reviewed the PR and you have run this for tier1 and tier2. I'll go ahead and
sponsor this now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24113#discussion_r2095226736
