On Tue, 20 May 2025 17:05:32 GMT, Daniel Fuchs <[email protected]> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cleanup
>
> test/jdk/com/sun/net/httpserver/ServerStopTerminationTest.java line 128:
>
>> 126:
>> 127: // Time the shutdown sequence
>> 128: final Duration delayDuration = Duration.ofSeconds(2);
>
> We should use a greater margin here since we're not expecting to wait for
> that duration, and probably use `Utils.adjustTimeout()` too. I'd suggest
> something like:
>
> Suggestion:
>
> final Duration delayDuration =
> Duration.ofSeconds(Utils.adjustTimeout(5));
done in the next commit
> test/jdk/com/sun/net/httpserver/ServerStopTerminationTest.java line 228:
>
>> 226: .uri(URI.create("http://";
>> 227: +
>> server.getAddress().getAddress().getHostAddress()
>> 228: + ":" + server.getAddress().getPort() +
>> "/"))
>
> We should use `URIBuilder` here to take care of IPv4 vs IPv6 etc...
done in the next commit
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25333#discussion_r2100751630
PR Review Comment: https://git.openjdk.org/jdk/pull/25333#discussion_r2100751035
