On Wed, 4 Jun 2025 11:12:02 GMT, Michael McMahon <micha...@openjdk.org> wrote:
> Hi,
>
> This is a fix to j.n.HttpCookie (which has a doc/spec change). So, I'm
> targeting it to 26.
> We currently do not obey the rule in RFC 6265 that says if both Max-Age and
> Expires attributes
> are present in a cookie, the Max-Age should take precedence.
>
> Thanks
> Michael
src/java.base/share/classes/java/net/HttpCookie.java line 1:
> 1: /*
Copyright year needs to be updated.
test/jdk/java/net/HttpCookie/MaxAgeExpires.java line 27:
> 25: * @test
> 26: * @bug 8351983
> 27: * @summary HttpCookie Parser Incorrectly Handles Cookies with Expires
> Attribute
Aren't we missing a `@run` tag?
test/jdk/java/net/HttpCookie/MaxAgeExpires.java line 63:
> 61: }
> 62:
> 63: static Test[] tests = new Test[] {
*Tip:* JUnit `@ParameterizedTest @CsvSource` can save us some boilerplate here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25636#discussion_r2127988396
PR Review Comment: https://git.openjdk.org/jdk/pull/25636#discussion_r2127987557
PR Review Comment: https://git.openjdk.org/jdk/pull/25636#discussion_r2127987253
