On Fri, 6 Jun 2025 08:25:44 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Add back removed SM tests
>
> The new version LGTM. I wonder if we should add `@bug 8358688` to the various 
> FilePublisher test - or just consider the fix as noreg-cleanup. On the one 
> hand those tests might have failed if you hadn't catched and transformed 
> NSFE. On the other hand they should pass whether this fix is present or not...

@dfuch, @jaikiran, I needed to push a test fix (de20dae) for `tier1,2` to pass 
– results are attached to the JBS issue. Would one of you mind approving the 
most recent changes, please?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25662#issuecomment-2965595660

Reply via email to