On Thu, 12 Jun 2025 09:21:08 GMT, Volkan Yazici <[email protected]> wrote:
>> Simplifies content streaming for `HttpRequest.BodyPublishers::ofFile(Path)`,
>> which delegates to `RequestPublishers.FilePublisher::create(Path)`. This
>> effectively replaces all usages of `FileInputStream::new` in `HttpClient`
>> with `Files::newInputStream(Path)`. See the JBS ticket description for the
>> full story.
>>
>> Also removing certain test files which were rendered redundant after
>> `SecurityManager` removal. We do this in this PR, since tests were added due
>> to touched lines.
>>
>> `tier1,2` results on b5f3c8dc6f4 are attached to the ticket.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Simplify `FilePublisherTest`
Marked as reviewed by dfuchs (Reviewer).
The person who wrote the test was probably concerned that
`fs.getPath("non-existent.txt");` could throw if passed a non-existing path.
Looking at the API documentation that doesn't seem a valid concern. The only
exception documented is `InvalidPathException` - so we should be good
-------------
PR Review: https://git.openjdk.org/jdk/pull/25662#pullrequestreview-2921525123
PR Comment: https://git.openjdk.org/jdk/pull/25662#issuecomment-2967127552
