On Thu, 12 Jun 2025 15:33:50 GMT, p-nima <d...@openjdk.org> wrote: >> The AuthenticationFilter did not respect the default retry limit of 3 >> retries in case of invalid credentials supplied. >> >> This PR helps to resolve the bug and tests it with default and updated retry >> limit set via `jdk.httpclient.auth.retrylimit=1`. >> >> The test is green with tiers 1, 2, 3 and the test is stable. > > p-nima has updated the pull request incrementally with one additional commit > since the last revision: > > apply review feedback and update java docs to clarify authentication retry > behaviour
Marked as reviewed by dfuchs (Reviewer). Changes requested by dfuchs (Reviewer). test/jdk/java/net/httpclient/HttpClientAuthRetryLimitTest.java line 9: > 7: * published by the Free Software Foundation. Oracle designates this > 8: * particular file as subject to the "Classpath" exception as provided > 9: * by Oracle in the LICENSE file that accompanied this code. This is the wrong Copyright for a test file. Tests shouldn't have the Classpath exception. Please copy the copyright from a nearby test. ------------- PR Review: https://git.openjdk.org/jdk/pull/25490#pullrequestreview-2922013950 PR Review: https://git.openjdk.org/jdk/pull/25490#pullrequestreview-2922019491 PR Review Comment: https://git.openjdk.org/jdk/pull/25490#discussion_r2143255094
