Simplifying JavaRuntimeURLConnection to avoid accidentally returning non-resource data to users.
This change has the following distinct parts: 1. Refactor code to use Node instead of directly accessing low level ImageLocation type. 2. Remove unnecessary use of "Resource" interface and related URL generation code (completely unreachable). 3. Adding comments explaining why there's a non-obvious distinction in how module and resource names are treated with respect to URL percent encoding. 4. Small constructor logic simplification (module name cannot be null anymore) 5. Small simplification around 'READER' use, since it is impossible for that to ever be null (other users of ImageReaderFactory already assume it could never be null, and code path analysis agrees). 6. Adding tests for the non-resource cases. 7. Adding extra test data to check the behaviour with respect to things like percent escaping (previously untested). 8. Adding TODO comments for things I could do in this PR or later (reviewer opinions welcome). ------------- Commit messages: - Copyright update. - Removing dead/unused code, simplifying connection logic and tidying up. Changes: https://git.openjdk.org/jdk/pull/25871/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25871&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8356645 Stats: 134 lines in 2 files changed: 43 ins; 55 del; 36 mod Patch: https://git.openjdk.org/jdk/pull/25871.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25871/head:pull/25871 PR: https://git.openjdk.org/jdk/pull/25871
