On Tue, 24 Jun 2025 16:14:13 GMT, Michael McMahon <micha...@openjdk.org> wrote:
>> Hi, >> >> This change is a follow on from https://bugs.openjdk.org/browse/JDK-8348986 >> In a couple of places, the new native code in that fix can potentially throw >> an exception while another exception is pending. This needs to be fixed. >> >> Thanks, >> Michael > > Michael McMahon has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains seven additional > commits since the last revision: > > - Merge branch 'JNI-8359268' of /Users/mimcmah/git/jdk/open into JNI-8359268 > - Merge branch 'master' into JNI-8359268 > - net_util.c update > - Merge branch 'master' into JNI-8359268 > - windows compile error > - update > - impl fix src/java.base/windows/native/libnet/Inet4AddressImpl.c line 93: > 91: int enh = getEnhancedExceptionsAllowed(env); > 92: if (enh == ENH_INIT_ERROR && (*env)->ExceptionCheck(env)) { > 93: return NULL; should it be `goto cleanupAndReturn;` instead? src/java.base/windows/native/libnet/Inet6AddressImpl.c line 88: > 86: int enh = getEnhancedExceptionsAllowed(env); > 87: if (enh == ENH_INIT_ERROR && (*env)->ExceptionCheck(env)) { > 88: return NULL; should it be `goto cleanupAndReturn;` instead? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25898#discussion_r2164789558 PR Review Comment: https://git.openjdk.org/jdk/pull/25898#discussion_r2164793497