On Wed, 2 Jul 2025 06:19:58 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which updates the >> `jdk.internal.net.http.HttpConnection` to keep track of the origin server >> for which the `HttpConnection` was constructed? This addresses >> https://bugs.openjdk.org/browse/JDK-8361060. >> >> This is an internal implementation change which will allow other parts of >> the JDK's HttpClient implementation to use the origin server information. An >> example of such usage is the alternate services that are going to be >> supported in the JDK's HttpClient upcoming implementation for HTTP/3. >> >> No new tests have been introduced and existing tests in tier1, tier2 and >> tier3 continue to pass. > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains seven additional > commits since the last revision: > > - Daniel's review - store Origin.host as lower case for DNS hostnames > - merge latest from master branch > - SNI server names can now be derived from the Origin instance > - strip the square brackets from URI's host when constructing an Origin > - support only lower case http and https literals for scheme in Origin > - add new line > - 8361060: Keep track of the origin server against which a > jdk.internal.net.http.HttpConnection was constructed I've updated the PR to include a test for the `Origin` class. No other changes. The test passes with these changes. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26041#issuecomment-3027734499
