> The PlainHttpConnection::connectAsync method implements a retry logic that 
> will call connect() again if connect() throws the first time. This will not 
> work, as the channel is closed when connect() throws. That logic should be 
> removed. Reconnection should only be attempted at a higher level 
> (MultiExchange).

Daniel Fuchs has updated the pull request incrementally with one additional 
commit since the last revision:

  Review feedback

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/26087/files
  - new: https://git.openjdk.org/jdk/pull/26087/files/a63206df..12ba2924

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=26087&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26087&range=01-02

  Stats: 8 lines in 1 file changed: 0 ins; 8 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/26087.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26087/head:pull/26087

PR: https://git.openjdk.org/jdk/pull/26087

Reply via email to