On Wed, 9 Jul 2025 05:49:30 GMT, Erik Gahlin <egah...@openjdk.org> wrote:

> Could I have a review of the change that ensures that the top frame for I/O 
> events is not an internal JDK method, such as FileReadEvent::offer? This 
> change is dependent on 
> [JDK-8361640](https://bugs.openjdk.org/browse/JDK-8361640).
> 
> Testing: tier1, tier2 + jdk/jdk/jfr
> 
> Thanks
> Erik

src/jdk.jfr/share/classes/jdk/jfr/events/FileReadEvent.java line 44:

> 42:               "java.io.DataInputStream",
> 43:               "java.io.FileInputStream",
> 44:               "java.io.InputStream",

Do you have any stack traces handy that could be pasted into the JBS issue or 
the PR so that it's clear why InputStream and Data*Stream frames are filtered?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26211#discussion_r2207508203

Reply via email to