On Fri, 11 Jul 2025 13:39:33 GMT, ayush <[email protected]> wrote:
> This is part of a series of diagnostic output updates to java.net tests to
> assist in the analysis of failures in IPv6 only environments
> for Linux there is not IPv4 configuration but the IPv4 stack remains enabled
> For macOS, and windows the IPv4 stacks are disabled, and IPv4 configuration
> removed
>
> add IPSupport::printPlatformSupport(System.out);
>
> to the start of main
This test-only change to add a diagnostic log looks fine to me. Before
integrating, please run this test in our CI, with your changes to make sure it
continues to work as expected.
test/jdk/java/net/NetworkInterface/IPv4Only.java line 52:
> 50: while (addrs.hasMoreElements()) {
> 51: InetAddress hostAddr = addrs.nextElement();
> 52: if ( hostAddr instanceof Inet6Address){
Hello Ayush, while you are changing this, you can additionally format that line
as follows:
if (hostAddr instanceof Inet6Address) {
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26265#pullrequestreview-3028609324
PR Review Comment: https://git.openjdk.org/jdk/pull/26265#discussion_r2212761988
