On Fri, 25 Jul 2025 07:30:47 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Hi all,
>>
>> I think the test java/net/ipv6tests/TcpTest.java should report
>> jtreg.SkippedException when there no IPV4 addresses or no IPV6 addresses,
>> rather than just print a messge and then report test run passes.
>>
>> Change has been verified locally, both enable ipv6 and disable ipv6 on
>> linux. When enable ipv6, test run passes; when disable ipv6, test report
>> jtreg.SkippedException as expected. Test-fix only, no risk.
>
> test/jdk/java/net/ipv6tests/TcpTest.java line 68:
>
>> 66: checkDebug(args);
>> 67: if (ia4addr == null) {
>> 68: throw new SkippedException("No IPV4 addresses: exiting
>> test");
>
> Hello @sendaoYan, isn't an `import jtreg.SkippedException;` required for this
> change?
This change require `import jtreg.SkippedException`, it's already import at
line 42.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26459#discussion_r2230389672
