On Fri, 25 Jul 2025 07:56:49 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this test-only change which fixes an accidental > use of `Thread.stop()`? This addresses > https://bugs.openjdk.org/browse/JDK-8358048. > > The test during it's termination attempts to close the `ProxyServer` and > invokes `ProxyServer.stop()`. The `ProxyServer` does not have a `stop()` > method of its own but since the `ProxyServer` is a `java.lang.Thread`, > calling `stop()` on the `ProxyServer` ends up calling the `Thread.stop()`. > The use of `stop()` in this test is accidental and the test should have used > `ProxyServer.close()`. > > The commit in this PR fixes the issue by removing the use of > `ProxyServer.stop()`. The test continues to pass with this change. This pull request has now been integrated. Changeset: d288ca28 Author: Jaikiran Pai <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/d288ca28be7bfba3abe9f54cefbe53e73c25707e Stats: 6 lines in 1 file changed: 1 ins; 1 del; 4 mod 8358048: java/net/httpclient/HttpsTunnelAuthTest.java incorrectly calls Thread::stop Reviewed-by: djelinski, alanb, vyazici ------------- PR: https://git.openjdk.org/jdk/pull/26473
