On Fri, 8 Aug 2025 14:07:28 GMT, Volkan Yazici <vyaz...@openjdk.org> wrote:
>> Can I please get a review of this change which proposes to address the issue >> noted in https://bugs.openjdk.org/browse/JDK-8365086? >> >> `java.net.CookieStore` has some APIs which return a `java.util.List`. These >> API are specified to return an immutable `List`. The JDK ships an >> implementation of the `CookieStore` - the `java.net.InMemoryCookieStore`. >> The implementations of the `getURIs()` and `get(URI)` methods in the >> `InMemoryCookieStore` currently return a `List` which is modifiable. >> >> The changes in this PR fix those two method to return an immutable `List` to >> match the specification. A new regression test has been introduced to >> reproduce the issue and verify the fix. >> >> I think this may not require a CSR since this fixes the implementation to >> match the already existing specification in `CookieStore`. I will create one >> if anyone suggests we should. > > test/jdk/java/net/CookieStoreTest.java line 45: > >> 43: * @run junit CookieStoreTest >> 44: */ >> 45: class CookieStoreTest { > > Otherwise you get a warning that the comment block should start with a `/**`: > > Suggestion: > > > class CookieStoreTest { Hello Volkan, is that warning generated by a IDE? I don't see it in IntelliJ: <img width="704" height="192" alt="ide" src="https://github.com/user-attachments/assets/b45345a2-343a-49ea-ab82-47bd40e6b87d"; /> ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26698#discussion_r2263124441
