On Tue, 5 Aug 2025 11:27:16 GMT, Volkan Yazici <[email protected]> wrote:
>> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)`
>> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient`
>> publisher to upload a certain region of a file. The new publisher does not
>> modify the state of the passed `FileChannel`, streams the file channel bytes
>> as it publishes (i.e., avoids reading the entire file into the memory), and
>> can be leveraged to implement sliced uploads. As noted in the Javadoc:
>>
>>> The file channel will not be closed upon completion. The caller is
>>> expected to manage the life cycle of the channel, and close it
>>> appropriately when not needed anymore.
>>
>> ### Implementation notes
>>
>> - `FileChannel` is preferred over `{Readable,Seekable}ByteChannel`, since
>> the latter does not provide a positional read without modifying the state of
>> the `FileChannel`, which is necessary to use a single `FileChannel` instance
>> to implement sliced uploads.
>> - `ofFileChannel(FileChannel,long,long)` is preferred over
>> `ofPath(Path,long,long)` to avoid overloading the maximum file descriptor
>> limit of the platform.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert the last commit: faa5d24d831
>
> The `send()`-vs-`sendAsync()` discrepancy will be addressed separately.
src/java.net.http/share/classes/java/net/http/HttpRequest.java line 755:
> 753: */
> 754: public static BodyPublisher ofFileChannel(FileChannel channel,
> long offset, long length) throws IOException {
> 755: Objects.requireNonNull(channel, "channel");
public FileChannelPublisher(FileChannel channel, long offset, long length)
throws IOException {
this.channel = Objects.requireNonNull(channel, "channel");
// ...
The FileChannelPublisher constructor already has a null value check for the
parameter channel, which is redundant
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26155#discussion_r2264700495
