On Wed, 20 Aug 2025 12:53:23 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> But what this PR do is change the timeoutFactor in general and find out all >> the tests which may timeout after the timeoutFactor has been changed. >> >> The old default timeout before this PR is 120 * 4, after this PR the new >> default is 120 * 1 > > @sendaoYan this PR changes the default timeoutFactor and so also has to > change quite a number of implicit and explicit timeouts. But that doesn't > mean that test configs that already set their own timeoutFactor should adjust > by the same factor! That just doesn't work for any test with an implicit > default timeout. Yes, this PR change the default timeoutFactor when the tested JVM options do not contains '-Xcomp', and at the same time also multiplies 4 of the timeout value defined in some tests. So after this PR, the tests which the timeout value has been multiplied 4 will have more timeout value, when the tested [JVM options contains '-Xcomp'](https://github.com/lkorinth/jdk/blob/286a2cc6e989a1c7dcd641bce792c6411bc1d0ea/make/RunTests.gmk#L593). I do agree this change, what I mean is this change has some side effect. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26749#discussion_r2288361080
