On Tue, 9 Sep 2025 13:15:27 GMT, Daniel Fuchs <[email protected]> wrote:
>> It is provided in the ctor above using `Utils.BUFSIZE`, which reads the >> `jdk.httpclient.bufsize` system property, and that can be negative. > > I think it would make more sense to make sure that Utils.BUFSIZE is > initialized to a strictly positive value and only assert here. It could be > useful to see if we have any test that set BUFSIZE to a small value - but if > we don't maybe we could go and clamp it to e.g. `2^10 <= BUFSIZE < 2^24` or > `2^10 <= BUFSIZE <= 2^23` if we want to keep powers of two. > (2^24 - 1 is the maximum allowed value for > [SETTINGS_MAX_FRAME_SIZE](https://www.rfc-editor.org/rfc/rfc9113.html#SETTINGS_MAX_FRAME_SIZE) > ) @dfuch, where shall I carry out that change? 1. In this PR? 2. In a follow-up a PR? 3. In a parallel PR to be merged before this one? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26876#discussion_r2334423774
