On Thu, 18 Sep 2025 16:31:07 GMT, Jaikiran Pai <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix `FileChannelPublisherTest` failures
>
> src/java.net.http/share/classes/jdk/internal/net/http/PullPublisher.java line
> 47:
>
>> 45:
>> 46: PullPublisher(CheckedIterable<T> iterable, Throwable throwable) {
>> 47: if ((iterable == null) == (throwable == null)) {
>
> Hello Volkan, I realize this style of condition check was done based on a
> review suggestion, so I don't expect you to undo it. Personally, I find this
> check hard to grasp and takes me a few rounds to understand what it is doing.
> But it's OK to leave it in this form.
This file will need a copyright year update.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26876#discussion_r2360193515
