On Thu, 9 Oct 2025 18:12:52 GMT, Josiah Noel <[email protected]> wrote:

>> Following the guideline of the last comment on 
>> [JDK-8349670](https://bugs.openjdk.org/browse/JDK-8349670?focusedId=14794649&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14794649),
>>  resolves the issue where sending a 1xx status code would close the input 
>> stream, preventing the server from reading the body. 
>> 
>> - When a 1xx status code is sent by `sendResponseHeaders`, the input/output 
>> streams will not be closed prematurely.
>> - sentHeaders will not be set to true when sending 1xx status codes
>> - 100-continue will be sent automatically when trying to read the 
>> inputstream if `Expect: 100-continue` header is present
>
> Josiah Noel has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update Send1xxResponsesTest.java

If we're not going to allow `sendResponseHeaders` to accept `1xx` codes then I 
believe we should modify it to throw if a `1xx` status code is passed, and 
document that formally in the API documentation of the method, rather than have 
the implementation send `1xx` as a final response.  Maybe this PR should do 
that.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27069#issuecomment-3397448910

Reply via email to