On Tue, 14 Oct 2025 13:33:37 GMT, Daniel Fuchs <[email protected]> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   forgot to include @bug id in the test definition
>
> test/jdk/java/net/httpclient/http3/H3RequestRejectedTest.java line 150:
> 
>> 148:                         .setOption(H3_DISCOVERY, HTTP_3_URI_ONLY)
>> 149:                         .uri(new URI(reqURI.toString() + "?iteration=" 
>> + i))
>> 150:                         .build();
> 
> To make sure the request is retried for the right reasons you might want to 
> switch to POST rather than GET here, as GET may be retried whatever the reset 
> reason.

That's a good point. I've updated the PR accordingly. The test continues to 
fail in the absence of the fix that's made in this PR and passes with it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27793#discussion_r2429278554

Reply via email to