On Tue, 21 Oct 2025 17:53:39 GMT, Daniel Fuchs <[email protected]> wrote:

>> `HttpTestEchoHandler` is a nice tip! In 92f07382f12, employed it and along 
>> with styling changes to remove all `HttpServerAdapters` qualifiers.
>> 
>> I'll go with importing whatever I need from `HttpServerAdapters`. I am 
>> uncomfortable with extending from `HttpServerAdapters` since its API surface 
>> is vast and certain method calls (e.g., `createClientBuilderFor()`) still 
>> must be qualified.
>
> If you implement HttpServerAdapters which is what almost all other tests do 
> then you can use `newClientBuilderForH3()` which is an instance method and 
> does not need to be qualified.

But neither `createClient()`, nor `main()` is an instance method – both are 
static. Hence, `newClientBuilderForH3()` is inaccessible and needs to be 
qualified.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27874#discussion_r2449332949

Reply via email to