On Fri, 10 Oct 2025 17:21:26 GMT, Daniel Fuchs <[email protected]> wrote:
>> Mikhail Yankelevich has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains four >> additional commits since the last revision: >> >> - race condition fix >> - Merge branch 'master' into JDK-8368625 >> - race condition fix >> - JDK-8368625: com/sun/net/httpserver/ServerStopTerminationTest.java fails >> intermittently in tier7 > > test/jdk/com/sun/net/httpserver/ServerStopTerminationTest.java line 127: > >> 125: // Complete the exchange one second into the future >> 126: final Duration exchangeDuration = Duration.ofSeconds(1); >> 127: final long startTime = System.nanoTime(); // taking custom >> start time just in case > > Suggestion: > > // taking start time before entering completeExchange to account for > possible > // delays in reaching server.stop(). > final long startTime = System.nanoTime(); Done in the next commit ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27670#discussion_r2459674960
