On Thu, 30 Oct 2025 13:36:42 GMT, Daniel Fuchs <[email protected]> wrote:
>> Thanks for your reviews. >> Regarding adding comments to the method, I will make the corresponding >> changes. >> As for the unit tests, it is indeed more reasonable to test this method >> directly rather than through the HTTP layer. >> With that in mind, would it be okay to make this method package-private so >> that it can be called from the test code and properly unit tested? > > Yes that would be OK. I plan to make this method `public static` so that it can be tested directly. This method doesn’t depend on the handler instance, and doing so will allow the test class which currently has no package declaration to invoke it. Please let me know if you have any concerns. Also, sorry for the long messages: this is my first contribution and I’m trying to be thorough. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28021#discussion_r2478238717
