On Tue, 4 Nov 2025 17:32:48 GMT, Volkan Yazici <[email protected]> wrote:
>> `java.net.Socket::setPerformancePreferences` was introduced in Java 1.5 with >> the intention of providing a declarative API for configuring the >> performance-wise characteristics of the underlying socket. It has always >> been a no-op and a corpus search does not reveal any significant usages of >> it. Recently merged [JDK-8366575] removes the SDP (Sockets Direct Protocol) >> support, and this further undermines the value of >> `setPerformancePreferences`. This PR deprecates `setPerformancePreferences` >> and friends _for removal_. >> >> [JDK-8366575]: https://bugs.openjdk.org/browse/JDK-8366575 > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision: > > Improve Javadoc src/java.base/share/classes/java/net/SocketImpl.java line 362: > 360: * > 361: * @deprecated This function has always been a no-op. > 362: * It is deprecated for removal without any replacement. The method description already has "By default, this method does nothing, unless it is overridden in a sub-class". What would you think about have the deprecated message be reduced down to "This method was intended to allow for protocols that are now obsolete"? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28129#discussion_r2491879876
