On Wed, 5 Nov 2025 15:17:35 GMT, Michael McMahon <[email protected]> wrote:

>> I'd like to return to this issue with a new PR that addresses the usability 
>> issue minimally. Namely to define numeric constants
>> for the counter-intuitive responseLength values in 
>> `HttpExchange.sendResponseHeaders`. The apidoc then refers to the constant 
>> names rather than the numeric values.
>> 
>> I've updated the implementation and some tests (though not all yet) to use 
>> the constant names. I'm open to suggestions on the names themselves. Once 
>> that is agreed, I'll update the remaining tests and any other call sites in 
>> the implementation.
>> 
>> Thanks,
>> Michael
>
> Michael McMahon has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   update

I don't disagree but adding new APIs is a bigger maintenance cost than adding 
two simple constants.
I believe the proposed change will improve the usability. The 
`sendResponseHeaders(int, long)` cannot be removed, and even if we added a new 
API it would still be here. There's also the impacts on the SPI to take into 
account.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28132#issuecomment-3492203779

Reply via email to